Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the github urls and remove unnecessary mentions #78

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

MaferMazu
Copy link
Contributor

Description

Updates the URLs to use the Open edX ones and removes unnecessary mentions.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @MaferMazu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@MaferMazu MaferMazu requested review from felipemontoya and feanil June 6, 2024 13:47
openedx-commerce.php Outdated Show resolved Hide resolved
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing most mentions to edunext is fine, but I would leave in the author field so that whoever is looking to modify or report bugs or whatnot knows who to expect as the author.

@MaferMazu MaferMazu force-pushed the mfmz/doc-update-and-remove branch from 3f7332f to 5b3ddee Compare June 7, 2024 12:23
@MaferMazu
Copy link
Contributor Author

Thanks, @felipemontoya. I updated the author. If you have more feedback, please share it with me. I am attentive if we can improve anything else.

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for updating all the links

@MaferMazu MaferMazu merged commit 2fd6e6f into openedx:main Jun 7, 2024
4 checks passed
@openedx-webhooks
Copy link

@MaferMazu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants