Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete unused workflows and generate zip with releases #71

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Apr 2, 2024

Description

This PR only modifies the GitHub workflows to work as expected (the continuous integration workflow is failing in the main branch):

  • Remove the commitlint created at the beginning of the development to maintain only the openedx commitlint.
  • Remove the continuous integration workflow because with the actual rules, we can't commit in the master directly, and we need an openedx/cla (see Ref 1). For that, I propose to use the versioning as in edx-enterprise; the author of the PR will be responsible for versioning and updating the changelog, and the maintainer will be responsible for creating the release if needed. I think openedx-filters works similarly, too. Please correct me if I'm wrong @felipemontoya @feanil. Or is it possible to avoid the openedx/cla restriction to github-actions[bot]?
  • We need to maintain the workflow for uploading the zip file to the release, and I proposed triggering this action with the release publication.

Testing instructions

Additional information

  • It is important to be able to create tags and releases to the workflow to upload the zip file used to install the plugin.

Ref 1

image

Checklist for Merge

  • Tested in a remote environment
  • Rebased master/main
  • Squashed commits

@openedx-webhooks
Copy link

Thanks for the pull request, @MaferMazu! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 2, 2024
@MaferMazu MaferMazu force-pushed the mfmz/fix-github-workflows branch from d559022 to 15737a3 Compare April 2, 2024 17:21
@MaferMazu MaferMazu force-pushed the mfmz/fix-github-workflows branch from 15737a3 to 13a58e5 Compare April 2, 2024 20:33
@MaferMazu MaferMazu force-pushed the mfmz/fix-github-workflows branch from 13a58e5 to e2b4751 Compare April 5, 2024 01:14
@MaferMazu MaferMazu changed the title fix: delete unused workflows and update them to check plugin version and generate zip with releases fix: delete unused workflows and generate zip with releases Apr 5, 2024
@felipemontoya
Copy link
Member

felipemontoya commented Apr 5, 2024

openedx-filters works similarly, too

yes it does. We create the releases manually.

triggering this action with the release publication.

This sounds reasonable and easy to maintain

@MaferMazu MaferMazu merged commit 66919d8 into openedx:main Apr 5, 2024
4 checks passed
@openedx-webhooks
Copy link

@MaferMazu 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants