Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added dummy-test to test git workflow & gitignore file #7

Merged
merged 2 commits into from
Jun 22, 2023
Merged

fix: added dummy-test to test git workflow & gitignore file #7

merged 2 commits into from
Jun 22, 2023

Conversation

julianramirez2
Copy link
Contributor

  • Created a test case in HelloTest file that will always give an OK result to check the workflow is working correctly.
  • Added gitignore to avoid composer files

@MaferMazu MaferMazu force-pushed the unit-testing-dummy-test branch from 682e56d to 1a3a4f6 Compare June 22, 2023 23:21
@MaferMazu MaferMazu force-pushed the unit-testing-dummy-test branch from 1a3a4f6 to 70db821 Compare June 22, 2023 23:23
@MaferMazu MaferMazu marked this pull request as ready for review June 22, 2023 23:25
@MaferMazu MaferMazu self-requested a review June 22, 2023 23:25
MaferMazu
MaferMazu approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, so we will have another PR (#5) to replace the HelloTest for a real test.

@julianramirez2 julianramirez2 merged commit 9db4984 into main Jun 22, 2023
@felipemontoya felipemontoya deleted the unit-testing-dummy-test branch March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaferMazu MaferMazu MaferMazu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianramirez2 @MaferMazu