Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:Update plugin_quickstart.rst #68

Closed
wants to merge 2 commits into from

Conversation

AyeshaSiddique01
Copy link

@AyeshaSiddique01 AyeshaSiddique01 commented Jan 30, 2024

The steps to enroll users in the course are updated.
We cannot enroll users in the Enrollment Management tab as there is no permission for anyone to enroll users in the course.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 30, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @AyeshaSiddique01! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@AyeshaSiddique01 AyeshaSiddique01 changed the title Update plugin_quickstart.rst docs:Update plugin_quickstart.rst Jan 30, 2024
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 30, 2024
@mphilbrick211
Copy link

Hi @AyeshaSiddique01! Thanks for this contribution. Would you mind adding a description of your changes to the top of the pull request?

Also, it looks like you're contributing on behalf of edly / arbisoft. Please have your manager reach out to [email protected] to have you added to their entity CLA agreement so we can get this pull request reviewed for you. Thank you!

@e0d
Copy link

e0d commented Feb 8, 2024

@AyeshaSiddique01 I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 9, 2024
@mphilbrick211
Copy link

Hi @AyeshaSiddique01! Thanks for this contribution. Would you mind adding a description of your changes to the top of the pull request?

Also, it looks like you're contributing on behalf of edly / arbisoft. Please have your manager reach out to [email protected] to have you added to their entity CLA agreement so we can get this pull request reviewed for you. Thank you!

Hi @AyeshaSiddique01! Just following up on this.

@mphilbrick211
Copy link

Hi @AyeshaSiddique01! Checking to see if you plan to pursue this pull request?

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Mar 20, 2024
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution @AyeshaSiddique01.

I think the step by step guide to create products and creating a sale is very nice. However I would suggest to move it to the how-to section of the docs as this quickstart is mostly focused on getting the configuration right.

- PHP 8.0 or greater is recommended
- Wordpress 6.3.1 or greater
- `WooCommerce plugin. <https://wordpress.org/plugins/woocommerce>`_
- Setup https://github.com/edly-io/tutor-contrib-wordpress.git plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a public repository (or it has been deleted since).

Also hosting wordpress via tutor is not a requirement. For the openedx-wordpress-ecommerce the only requirements are as listed before.

@AyeshaSiddique01
Copy link
Author

Hi @AyeshaSiddique01! Thanks for this contribution. Would you mind adding a description of your changes to the top of the pull request?
Also, it looks like you're contributing on behalf of edly / arbisoft. Please have your manager reach out to [email protected] to have you added to their entity CLA agreement so we can get this pull request reviewed for you. Thank you!

Hi @AyeshaSiddique01! Just following up on this.

I have already

Hi @AyeshaSiddique01! Checking to see if you plan to pursue this pull request?

Yes, I have a plan to pursue this pull.

@AyeshaSiddique01
Copy link
Author

Thanks a lot for this contribution @AyeshaSiddique01.

I think the step by step guide to create products and creating a sale is very nice. However I would suggest to move it to the how-to section of the docs as this quickstart is mostly focused on getting the configuration right.

Sure

@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed inactive PR author has been unresponsive for several months labels Mar 26, 2024
@e0d
Copy link

e0d commented Mar 28, 2024

@AyeshaSiddique01 I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 28, 2024
@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label May 1, 2024
@mphilbrick211
Copy link

Hi @AyeshaSiddique01! I'm going to close this pull request for now, however, we can reopen if you'd like to pursue in the future. Thanks!

@openedx-webhooks
Copy link

@AyeshaSiddique01 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants