feat: created new workflow for release zip with current version #54
Conversation
|
Thanks for the pull request, @julianramirez2! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
|
Hi @julianramirez2! Thanks for this contribution! Please let me know if you have any questions re: filling out the CLA form. If you are submitting on behalf of eduNEXT, you'll need to have your manager email [email protected] and have you added to eduNEXT's entity agreement (if they haven't done so already). |
Hi @mphilbrick211, I sent the CLA form a couple of days ago but I still have no response in my email. |
Thanks, @julianramirez2! I'm looking into this for you. |
|
@julianramirez2 - we are not seeing it on our end. Can you reach out to [email protected] and confirm your personal email address? We will send it to you from there. |
|
Hi @julianramirez2 - it looks like you're contributing on behalf of eduNEXT. In this case, we need to add you to eduNEXT's existing entity agreement. @juancamilom could you please confirm that we should add @julianramirez2? |
As far as I understood from now on I was going to start contributing not on behalf of EduNext but independently. I sent the request with the e-mail "[email protected]". If necessary, I can either refill the CLA or send an email to the address you provided. |
|
thanks for flagging this @mphilbrick211 . best :) |
|
@julianramirez2 - you've been added to the eduNEXT entity CLA. It might take 24 hours to reflect in github. The CLA check should turn green when you rebase in the next day or so. Please let me know if you have any issues. Thanks! |
|
Hi @julianramirez2! When you get a moment, could you please rebase so we can make sure your CLA check turns green? Thanks! |
|
@julianramirez2, please remember to change the zip file name to follow #53 |
Done. |
|
@julianramirez2 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
An important error in the release generation process has been corrected. Previously, when generating a release, the 'zip' file of the plugin was being created with dependencies still tagged with the previous version. In other words, if transitioning from v1.0.0 to v2.0.0, the version tag in the files remained as v1.0.0 due to a workflow order issue.
To address this, we now allow the 'bumpversion' workflow to execute, and only after its successful completion, the 'upload-release-zip.yml' process is triggered. This process generates a zip file with the current version tag and adds it to the finalized release.
Testing instructions
"For testing purposes, it's best to fork the repository, manually create an initial version tag so that the workflow can recognize that one already exists and know which version to set, and then make a change to the 'main' branch to trigger the workflow.
Additional information
At the end, a zip file is generated with the name 'openex-ecommerce.zip,' which contains the necessary files and dependencies for the installation. The name has been changed in accordance with the rules required by WordPress.