feat: course id fields restriction & js uncaught element bug fixed #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaferMazu @andres-arango-aptitude can you check this, please? |
MaferMazu
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a JavaScript file that restricts the course ID fields in the enrollment form and product form for Open edX courses, to make the "course-v1:" string at the beginning mandatory. Also, while running the JavaScript code, there were some error messages appearing in the console because the code was trying to get an element that was not present on the page. To fix this issue, an if structure was added to the code to verify if the element is present on the page before using it.
Testing instructions
Go to the enrollment form and the product page and try to modify the course ID.
Checklist for Merge