Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course_id read-only, naming improvements and css styles #37

Merged
merged 10 commits into from
Sep 8, 2023

Conversation

julianramirez2
Copy link
Contributor

Description

Minor changes were made to the Enrollment form to adjust styles and fix a bug where the 'View Order' button was not displayed when creating a new enrollment request.

Testing instructions

Access the staging environment and review the styles of the form.

Additional information

This is how the front-end looks like:

image

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@julianramirez2
Copy link
Contributor Author

@MaferMazu can you check this PR, please?

@MaferMazu MaferMazu self-requested a review September 8, 2023 21:05
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but I suggest you change the PR name before squash and merge to have a more accurate description of the history.
Maybe something like feat: course_id read-only and naming improvements

@julianramirez2 julianramirez2 changed the title fix: general enrollment form fixes fix: course_id read-only, naming improvements and css styles Sep 8, 2023
@julianramirez2 julianramirez2 merged commit db1a2b1 into main Sep 8, 2023
@felipemontoya felipemontoya deleted the enrollment-fixes branch March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants