-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enrollment request form changes #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @julianramirez2, can you double-check my changes?
Do we want to add the phpcs-report.xml in our .gitignore?
@andres-arango-aptitude, what do you think about this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's good to me
Looks good to me, and yes, it's better if we include the phpcs-report.xml in the gitignore file. |
Description
All necessary adjustments to the enrollments form have been completed:
Each action, both for the checkboxes and the buttons (Save Locally, Sync, and Send to API), has been properly refactored to indicate the correct action.
Additional information
This is how the front-end looks like:
And this is how the tooltip looks like:
Checklist for Merge