Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wpcs workflow and code quality improved #31

Merged
merged 14 commits into from
Aug 30, 2023

Conversation

julianramirez2
Copy link
Contributor

@julianramirez2 julianramirez2 commented Aug 30, 2023

Description

The implementation of a new CodeSniffer workflow was carried out, which is exclusively based on WordPress Coding Standards, ensuring the quality of our code. Additionally, necessary code adjustments were made to align it with these rules

Testing instructions

To test, you should access the local environment and verify all project functionalities.

Additional information

Changes were made to the code structure, including file naming, variable handling, and the addition of crucial properties to the composer, enabling class autoloading for PHPUnit.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@julianramirez2 julianramirez2 changed the title feat: WPCS workflow and code quality improved feat: wpcs workflow and code quality improved Aug 30, 2023
@julianramirez2 julianramirez2 force-pushed the code-quality-check branch 2 times, most recently from 333a7cc to 16a8857 Compare August 30, 2023 19:44
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianramirez2 thanks for this PR, we really need it. I left you some comments but in general looks good. Let me know when you review my comments.

test/.phpunit.result.cache Outdated Show resolved Hide resolved
vendor/composer/installed.php Outdated Show resolved Hide resolved
.github/workflows/linting.yml Outdated Show resolved Hide resolved
.github/workflows/linting.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✨

@julianramirez2 julianramirez2 merged commit 50f9cb1 into main Aug 30, 2023
@felipemontoya felipemontoya deleted the code-quality-check branch March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants