-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable redirection button to order or enrollment request #20
Conversation
@andres-arango-aptitude, can you help us with your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
fix: phpcs spacing in comments fix: phpcs spacing fixes fix: spaces instead of tabs fix: phpcs spacing and characters control fix: echo line exceeds 85 characters fix: phpcs fixes in admin file fix: general phpcs fixes in info form file fix: phpcs fixes in main plugi file fix: character limit reached fix: characters limit reached in main file fix: phpcs spaces fixed fix: characters limit reached in main file fix: plugin file spacing fixed fix: log manager variable name fixed
2a8ffd7
to
ac3fcd6
Compare
Can you add screenshots to the PR and briefly explain how this feature works? |
I have included the screenshots in the "Additional Information" section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good.
Can you adjust the box in the Order to be the same height to the button to maintain the visual consistency of the form in the Enrollment Request? or do you want to fix that as a visual ergonomic thing?
I prefer to fix it in the visual ergonomy pull requests to leave this PR clean as possible. |
Description
The functionality has been added to the Enrollment Request, so that whenever there is an associated order_id, a button labeled "View Order" is enabled, allowing users to be redirected to the associated order with just one click. Now, within an order, in the product items, if an Enrollment Request ID is set for them, a button is enabled that allows users to be redirected to the Enrollment Request associated with that item in that order.
Testing instructions
Go to the Enrollment Request and enter an order_id in the order_id field, then save the changes. Click on the button to be redirected to the associated order. Similarly, from an order, if any product item has a set Enrollment Request ID, click on the corresponding button to be redirected to the linked Enrollment Request.
Additional information
To show it better I will explain the functionalities with pictures:
If you input the order number in the Enrollment Request, the "View Order" button will become active.
When you access the order, you will come across a field that contains items classified as courses.
If a field is empty, it will appear disabled.
And also like this in order items.
Checklist for Merge