-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: operation logs for enrollment requests #17
Conversation
18c5bf9
to
5d63b4e
Compare
Thanks for taking that comment into account. And I think you mean the newer log at the bottom and the oldest at the top. Btw thanks for removing the general info field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left you some comments. Please let me know what you think.
admin/views/Openedx_Woocommerce_Plugin_Enrollment_Info_Form.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julianramirez2 remember to add the end line in includes/model/Openedx_Woocommerce_Plugin_Logs.php
.
I test this in Stage and looks good. I have one comment: if we create an Enrollment Request always, the action is "Object Created," but if we create the object with another action, for example, "Process request," we lose that information. Maybe it's a good idea only use the "Object Created" if we don't have action and I created that object. What do you think?
The rest looks good to me ✨
I wonder if @jvegalo has some time to do a quick review of this.
I just added a new field called "object_status" to clarify this. So, the request type will remain in the information, and we'll also have this new field indicating if an object is new with the message "Object Created" or if it has been modified with the message "Object Modified." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin/views/Openedx_Woocommerce_Plugin_Enrollment_Info_Form.php
Outdated
Show resolved
Hide resolved
Thanks for your contribution, @arangos. |
@MaferMazu Ready for merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for taking all into account @julianramirez2. Please add an end line in the CSS file and you can squash and merge.
Description
A logging system has been implemented to enable traceability of operations performed on Enrollment Requests. This system will describe the action focusing on the questions: "Who?" "When?" and "What?"
For each Enrollment Request accessed, a panel will appear on the right-hand side, displaying the history of actions carried out on the post.
Testing instructions
To test the entire functionality, the idea is to access the Enrollments Manager and create a new Enrollment Request. Then, make changes to it and compare the actions taken with the generated logs.
Checklist for Merge