Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code refactoring and namespace/use statements. #11

Merged
merged 7 commits into from
Jun 28, 2023

Conversation

julianramirez2
Copy link
Contributor

@julianramirez2 julianramirez2 commented Jun 28, 2023

Description

A refactoring of the code was done in order to decouple the code from the Openedx_Woocommerce_Plugin_Admin file for:

  • Facilitate future implementations
  • Facilitate the testing process of the class.

In addition, namespace and their respective "use" were declared if necessary in each class in order to make easier and cleaner the invocation of the classes between the plugin files. It will benefit us as developers for a better understanding and improve the scalability of the code.

Testing instructions

To test, perform the normal flow of activation and deactivation of the plugin and make the flow of an "Enrollment Request" in the dashboard (with the functionalities that we have so far) to check that there is no invocation to an existing class that cannot be found because of the namespace statements.

Checklist for Merge

  • Tested in a remote environment
  • Rebased master/main
  • Squashed commits

@julianramirez2 julianramirez2 changed the title Fix code refactoring fix: code refactoring and namespace/use statements. Jun 28, 2023
@julianramirez2 julianramirez2 requested a review from MaferMazu June 28, 2023 19:49
@MaferMazu MaferMazu requested a review from jvegalo June 28, 2023 20:48
@MaferMazu
Copy link
Contributor

This looks good to me. I would like @jvegalo opinion, and if he thinks that it is okay and doesn't have improvement comments, you can squash and merge.

@julianramirez2 julianramirez2 merged commit 7e280e4 into main Jun 28, 2023
@felipemontoya felipemontoya deleted the fix-code-refactoring branch March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants