Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add publish to wordpress svn action #103

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Nov 18, 2024

Description

This PR create and use a github action to publish the code in our WordPress SVN. The implementation is based on richard-muvirimi/deploy-wordpress-plugin workflow.

Testing instructions

I tested this action here https://github.com/eduNEXT/openedx-wordpress-ecommerce/actions/runs/12170352292/job/33945121718
And it worked as expected.
I had the 2.0.6 version, and the workflow added the 2.0.7.

To see the SVN https://svn.riouxsvn.com/openedx-commerc

Additional information

Related to #97

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation (N/A)
  • Rebased master/main
  • Squashed commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 18, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 18, 2024

Thanks for the pull request, @MaferMazu!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @mafermazu. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@MaferMazu MaferMazu linked an issue Nov 18, 2024 that may be closed by this pull request
@MaferMazu MaferMazu marked this pull request as ready for review November 18, 2024 18:25
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that repo has not seen any updates in 2 years, are we sure about this. As this is a commerce plugin I'm more wary of using 3rd party workflows for deploying the code to wordpress.

@MaferMazu
Copy link
Contributor Author

That's the best workflow I've found. But it is okay if we want to maintain an action for security; I could work on it at the end of the week.

@MaferMazu MaferMazu force-pushed the mfmz/publish-to-svn branch from 481c917 to db0117c Compare December 4, 2024 23:50
@MaferMazu MaferMazu requested a review from feanil December 4, 2024 23:52
@MaferMazu
Copy link
Contributor Author

MaferMazu commented Dec 4, 2024

@feanil @felipemontoya I updated this PR. I extract the main functions of the existing workflow to create our action.

I tested this action here https://github.com/eduNEXT/openedx-wordpress-ecommerce/actions/runs/12170352292/job/33945121718
And it worked as expected.
I had the 2.0.6 version, and the workflow added the 2.0.7.

To see the SVN https://svn.riouxsvn.com/openedx-commerc

@MaferMazu MaferMazu force-pushed the mfmz/publish-to-svn branch from db0117c to acd0dec Compare December 4, 2024 23:57
@MaferMazu MaferMazu force-pushed the mfmz/publish-to-svn branch from acd0dec to 3fa0509 Compare December 4, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

["FEAT"] Deploy changes to SVN repo on release
3 participants