-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add publish to wordpress svn action #103
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @MaferMazu! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
a942981
to
d077c5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that repo has not seen any updates in 2 years, are we sure about this. As this is a commerce plugin I'm more wary of using 3rd party workflows for deploying the code to wordpress.
That's the best workflow I've found. But it is okay if we want to maintain an action for security; I could work on it at the end of the week. |
481c917
to
db0117c
Compare
@feanil @felipemontoya I updated this PR. I extract the main functions of the existing workflow to create our action. I tested this action here https://github.com/eduNEXT/openedx-wordpress-ecommerce/actions/runs/12170352292/job/33945121718 To see the SVN https://svn.riouxsvn.com/openedx-commerc |
db0117c
to
acd0dec
Compare
acd0dec
to
3fa0509
Compare
Description
This PR create and use a github action to publish the code in our WordPress SVN. The implementation is based on richard-muvirimi/deploy-wordpress-plugin workflow.
Testing instructions
I tested this action here https://github.com/eduNEXT/openedx-wordpress-ecommerce/actions/runs/12170352292/job/33945121718
And it worked as expected.
I had the 2.0.6 version, and the workflow added the 2.0.7.
To see the SVN https://svn.riouxsvn.com/openedx-commerc
Additional information
Related to #97
Checklist for Merge