-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: admin enqueue order #102
Conversation
Thanks for the pull request, @MaferMazu! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
cb5412b
to
ff449f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. The PR looks good and the explaining video is super clear
Description
This PR is for fix #101
includes/class-openedx-commerce.php
to the admin enqueue_scripts (admin/class-openedx-commerce-admin.php
).define_enqueue_scripts
function fromincludes/class-openedx-commerce.php
because it is no longer needed.includes/class-openedx-commerce.php
to the admin enqueue_styles (admin/class-openedx-commerce-admin.php
).Testing instructions
Use this version and:
Screenshots
This video shows how every commit resolves a note/warning in the admin dashboard and, at the end, shows how this does not affect the js and the plugin's styles.
Screencast.from.2024-11-01.11-10-07.webm
Note: In the video, the Enrollment Operation Logs in the Enrollment Requests don't show all the borders colored, but they are.
Checklist for Merge