Adds missing __init__.py files [FC-0030] #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
pomegranited
force-pushed
the
jill/linting
branch
2 times, most recently
from
6e6788f to
e04bf96
Compare
and fixes resulting pylint issues, including a number of translation-of-non-string errors: i18n function _() must be called with a literal string
and fixes resulting pylint issues.
pomegranited
force-pushed
the
jill/linting
branch
3 times, most recently
from
f0c458f to
5d4dcd9
Compare
ChrisChV
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
@pomegranited Looks good to me, thanks for this work 👍
- I tested this: A ran the tests and checked the coverage and warnings
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes documentation.
bradenmacdonald
requested changes
Oct 4, 2023
pomegranited
force-pushed
the
jill/linting
branch
from
868057d to
95c0e5a
Compare
bradenmacdonald
approved these changes
Oct 6, 2023
|
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing
__init__.pyfiles, and fixes the resulting linting errors, plus some minor test fixes:tests/(see previous coverage report)This change shouldn't require any manual testing, just a code review.
Follow-up to #87 (comment)
Private-ref: FAL-3477