Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update piptools to fix make requirements error #85

Closed
wants to merge 1 commit into from

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Sep 26, 2023

Description

Running make requirements outputs the following error:

pip install -qr requirements/pip-tools.txt
pip-sync requirements/dev.txt requirements/private.*
Traceback (most recent call last):
  File "/home/user/.virtualenvs/openedx-learning/bin/pip-sync", line 5, in <module>
    from piptools.scripts.sync import cli
  File "/home/user/.virtualenvs/openedx-learning/lib/python3.8/site-packages/piptools/scripts/sync.py", line 16, in <module>
    from .. import sync
  File "/home/user/.virtualenvs/openedx-learning/lib/python3.8/site-packages/piptools/sync.py", line 11, in <module>
    from pip._internal.commands.freeze import DEV_PKGS
ImportError: cannot import name 'DEV_PKGS' from 'pip._internal.commands.freeze' (/home/user/.virtualenvs/openedx-learning/lib/python3.8/site-packages/pip/_internal/commands/freeze.py)
make: *** [Makefile:61: requirements] Error 1

This seems to be related to an incompatibility. with pip 23.3

Updating piptools fixed the issue.

More info

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 26, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 26, 2023

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido rpenido marked this pull request as ready for review September 26, 2023 13:25
@rpenido rpenido closed this Sep 27, 2023
@openedx-webhooks
Copy link

@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@rpenido rpenido deleted the rpenido/upgrade-piptools branch September 27, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants