-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new delete object tags function #71
feat: new delete object tags function #71
Conversation
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
7cbe2b0
to
97e41d1
Compare
@ChrisChV I think this is ready to review |
@rpenido Looks good 👍 Could you bump the version of the package so @pomegranited can merge and create a new tag?
|
I've been thinking about it like this: The MVP release of the openedx_tagging will be 1.0 -- until then, this library isn't really "in production use". So everything we're doing to support that MVP is still a patch version. Does that make sense to you and @ChrisChV ? I'm happy to be corrected here. |
84542a3
to
3146dbe
Compare
From SemVer docs:
FAQ:
I re-tagged it as 0.1.4, following the previous convention! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR adds the
delete_object_tags
to the oel_tagging api. This method will be used to clean the object tags applied to an object on its deletion, for example.