Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new delete object tags function #71

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Aug 10, 2023

This PR adds the delete_object_tags to the oel_tagging api. This method will be used to clean the object tags applied to an object on its deletion, for example.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 10, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 10, 2023

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido rpenido changed the title feat: add delete objec tags feat: add delete object tags Aug 10, 2023
@rpenido rpenido force-pushed the rpenido/fal-3460-content-auto-tagging-by-system-taxonomies branch from 7cbe2b0 to 97e41d1 Compare August 15, 2023 17:23
@rpenido rpenido marked this pull request as ready for review August 15, 2023 17:23
@rpenido
Copy link
Contributor Author

rpenido commented Aug 15, 2023

@ChrisChV I think this is ready to review

@rpenido rpenido changed the title feat: add delete object tags feat: new delete object tags function Aug 15, 2023
@ChrisChV
Copy link
Contributor

@rpenido Looks good 👍 Could you bump the version of the package so @pomegranited can merge and create a new tag?

  • I read through the code and checked the tests.
  • I ran the tests

@rpenido
Copy link
Contributor Author

rpenido commented Aug 16, 2023

@ChrisChV
Done 85f1111!

PS: I saw that we were bumping the patch version instead of minor for new backward compatible functionalities (which is not exactly semver). Is it ok to bump the minor version now, as this is not a bugfix?

@pomegranited
Copy link
Contributor

pomegranited commented Aug 17, 2023

@rpenido

PS: I saw that we were bumping the patch version instead of minor for new backward compatible functionalities (which is not exactly semver). Is it ok to bump the minor version now, as this is not a bugfix?

I've been thinking about it like this: The MVP release of the openedx_tagging will be 1.0 -- until then, this library isn't really "in production use". So everything we're doing to support that MVP is still a patch version.

Does that make sense to you and @ChrisChV ? I'm happy to be corrected here.

@rpenido rpenido force-pushed the rpenido/fal-3460-content-auto-tagging-by-system-taxonomies branch from 84542a3 to 3146dbe Compare August 17, 2023 20:29
@rpenido
Copy link
Contributor Author

rpenido commented Aug 17, 2023

From SemVer docs:

  1. Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

FAQ:

How should I deal with revisions in the 0.y.z initial development phase?

The simplest thing to do is start your initial development release at 0.1.0 and then increment the minor version for each subsequent release.

How do I know when to release 1.0.0?

If your software is being used in production, it should probably already be 1.0.0. If you have a stable API on which users have come to depend, you should be 1.0.0. If you’re worrying a lot about backward compatibility, you should probably already be 1.0.0.

I re-tagged it as 0.1.4, following the previous convention! 😄

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for adding this @rpenido !

  • I tested this by running the automated tests.
  • I read through the code and tests, and ensured they covered the known use cases.
  • I checked for accessibility issues N/A
  • Includes documentation
  • Commit structure follows OEP-0051

@pomegranited pomegranited merged commit 79c16a0 into openedx:main Aug 18, 2023
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@pomegranited pomegranited deleted the rpenido/fal-3460-content-auto-tagging-by-system-taxonomies branch August 18, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants