Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tag_object param order #165

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Feb 21, 2024

Description

This PR changes the param order in the tag_content function and the tests accordingly.
PS: all function calls at edx-platform use named parameters, so this PR doesn't impact there.

Testing Instructions

  • Please ensure that the tests cover the expected behavior

Private ref: FAL-3621

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 21, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 21, 2024

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido rpenido marked this pull request as ready for review February 22, 2024 12:54
@rpenido
Copy link
Contributor Author

rpenido commented Feb 22, 2024

Hi @bradenmacdonald ! This is a small fix that I made when I was developing openedx/modular-learning#180.
Can you review it?

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you ❤️

@bradenmacdonald
Copy link
Contributor

Does this break anything in edx-platform though? Will we have to make corresponding changes on that side before bumping the version?

@rpenido
Copy link
Contributor Author

rpenido commented Feb 23, 2024

Does this break anything in edx-platform though? Will we have to make corresponding changes on that side before bumping the version?

No. All calls from edx-platform use named parameters.

@bradenmacdonald bradenmacdonald merged commit bbedb53 into openedx:main Feb 23, 2024
7 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the rpenido/refactor_tag_object_param_order branch February 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants