Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_taxonomy_by_export_id method [FC-0049] #164

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Feb 21, 2024

Description

This PR adds a get_taxonomy_by_export_id method. This method will be used in to import taxonomy data.

Supporting information

Testing Instructions

  • Please ensure that the tests cover the expected behavior

Private ref: FAL-3621

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 21, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 21, 2024

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido rpenido force-pushed the rpenido/fal-3675-add-get-taxonomy-by-external-id-function branch from 7222b55 to d7b46a4 Compare February 22, 2024 13:50
@rpenido rpenido changed the title feat: add get_taxonomy_by_export_id method feat: add get_taxonomy_by_export_id method [FC-0049] Feb 22, 2024
@rpenido rpenido marked this pull request as ready for review February 23, 2024 21:55
Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido This looks good to me, great work! 👍

  • I tested this: I confirmed the tests check for the functionality
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 -- @rpenido could you push a version bump, and I can merge & tag a new release.

  • I tested this on my devstack shell.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation
  • User-facing strings are extracted for translation N/A

openedx_tagging/core/tagging/models/base.py Outdated Show resolved Hide resolved
@rpenido
Copy link
Contributor Author

rpenido commented Feb 28, 2024

👍 -- @rpenido could you push a version bump, and I can merge & tag a new release.

Done: 0b9a9d7

@pomegranited pomegranited merged commit 112855f into openedx:main Feb 28, 2024
7 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@pomegranited pomegranited deleted the rpenido/fal-3675-add-get-taxonomy-by-external-id-function branch February 28, 2024 22:46
@pomegranited pomegranited restored the rpenido/fal-3675-add-get-taxonomy-by-external-id-function branch February 28, 2024 22:46
@rpenido rpenido deleted the rpenido/fal-3675-add-get-taxonomy-by-external-id-function branch March 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants