-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add export_id field on Taxonomy #145
feat: Add export_id field on Taxonomy #145
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@@ -121,7 +121,7 @@ def import_tags( | |||
task.end_success() | |||
|
|||
return True, task, tag_import_plan | |||
except Exception as exception: # pylint: disable=broad-exception-caught | |||
except Exception as exception: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generated a warning on the lint
openedx_tagging/core/tagging/migrations/0015_taxonomy_export_id.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits/questions, but everything else looks perfect. 👍
@ChrisChV Let me know if you need me to do a second review?
- I tested this in my devstack using the PR test instructions
- I read through the code
-
I checked for accessibility issuesN/A here - Includes documentation -- adds help_text for new field, docstrings where needed
- User-facing strings are extracted for translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a new
export_id
field onTaxonomy
model.Support information
Testing instruction
Before run migration
python manage.py runsever
.python manage.py createsuperuser
.python manage.py migrate
.export_id
export_id
on Django admin.export_id