-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: [FC-0074] add details for illustrating how filters work #231
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d6672b9
docs: add diagram for illustrating how filters work
mariajgrimaldi b8e1cdf
refactor: match description to diagram and make reference to glossary
mariajgrimaldi 6fe944a
refactor: make f_2 raise an example to explain diagram
mariajgrimaldi 2d3ef09
refactor: drop references to filter tooling but leave in glossary
mariajgrimaldi 8c7f6a1
refactor: reorganize diagram in its own section
mariajgrimaldi 49e4004
refactor: use section for real-life workflow example and tweak wording
mariajgrimaldi e11ab05
refactor: upload latest diagram version
mariajgrimaldi e5c15f8
docs: add details about what type of data the filter handles
mariajgrimaldi 4953e19
refactor: address PR review
mariajgrimaldi 58848fc
refactor: use latest diagram version
mariajgrimaldi adcc7e2
refactor: replace incorrect raise statement by return in diagram
mariajgrimaldi 56929d0
fix: remove duplicate title
mariajgrimaldi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the diagram I'm using kwargs because that's how filters are called, by using keyword arguments. Now, I'm not sure if using kwargs makes the explanation more cumbersome to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Python developers should understand
kwargs
, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, of course. I was referring to how good (fluent?) it read, but it should be fine.