Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [FC-0074] add glossary for openedx-events ecosystem #407

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Oct 11, 2024

Description

This PR:

  1. Creates a glossary document for Open edX Events terminology in the reference section.
  2. Uses sphinx utilities to implement a glossary.
  3. References glossary throughout all documents when needed.

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 11, 2024

Thanks for the pull request, @mariajgrimaldi!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/hooks-extension-framework. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 11, 2024
@mariajgrimaldi mariajgrimaldi changed the title docs: add glossary for openedx-events ecosystem docs: [FC-0074] add glossary for openedx-events ecosystem Oct 28, 2024
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 30, 2024
Event Definition
An event is a signal that is emitted when a specific action occurs in the platform. The event definition is the instantiation of the ``OpenEdxPublicSignal`` class that defines the structure and metadata of an event. This definition includes information such as the event name, description, payload, and version. Event definitions are used to create events which are later imported into the services and are triggered by using the ``send_event`` method.

.. _Events Payload ADR: :doc: `/decisions/0003-events-payload`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware definitions about the event bus are missing here, but I'll add them later when I start improving the event bus docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth adding in the terms, with a definition of "To be added soon" or something so we don't forget?

@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review November 4, 2024 14:16
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner November 4, 2024 14:16
@mariajgrimaldi mariajgrimaldi requested a review from sarina November 4, 2024 16:36
docs/quickstarts/use-events-to-call-webhook.rst Outdated Show resolved Hide resolved
docs/reference/glossary.rst Outdated Show resolved Hide resolved
docs/reference/glossary.rst Outdated Show resolved Hide resolved
Event Definition
An event is a signal that is emitted when a specific action occurs in the platform. The event definition is the instantiation of the ``OpenEdxPublicSignal`` class that defines the structure and metadata of an event. This definition includes information such as the event name, description, payload, and version. Event definitions are used to create events which are later imported into the services and are triggered by using the ``send_event`` method.

.. _Events Payload ADR: :doc: `/decisions/0003-events-payload`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth adding in the terms, with a definition of "To be added soon" or something so we don't forget?

docs/reference/glossary.rst Outdated Show resolved Hide resolved
docs/reference/glossary.rst Show resolved Hide resolved
@mariajgrimaldi
Copy link
Member Author

@sarina: I completely forgot to let you know I addressed your comments 🫠. Thank you for the thorough review!

@sarina
Copy link
Contributor

sarina commented Nov 7, 2024

It looks great now, merge when you're ready!

@mariajgrimaldi mariajgrimaldi merged commit 55bd6de into main Nov 18, 2024
8 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/add-glossary-ref branch November 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants