Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Content Library Collections signals [FC-0062] #386

Merged
merged 9 commits into from
Sep 6, 2024
Merged

feat: Add Content Library Collections signals [FC-0062] #386

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8101eb4
feat: Add Content Library Collections signals
yusuf-musleh Aug 25, 2024
dc8c283
Merge branch 'main' into yusuf-musleh/content-library-collections-sig…
pomegranited Sep 2, 2024
60ef0a3
fix: use collection_key (str) instead of id (int)
pomegranited Sep 4, 2024
b6ab399
docs: update CHANGELOG
pomegranited Sep 4, 2024
65701f1
feat: Deprecates CONTENT_OBJECT_TAGS_CHANGED in favor of CONTENT_OBJE…
pomegranited Sep 6, 2024
18a3544
Merge remote-tracking branch 'origin/main' into yusuf-musleh/content-…
pomegranited Sep 6, 2024
b4e6e76
fix: fix conflicts in CHANGELOG
pomegranited Sep 6, 2024
5e89cbe
fix: use content_library subdomain for new events
pomegranited Sep 6, 2024
1399908
fix: add library collection events to changelog
navinkarkera Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ Change Log
Unreleased
----------

Added
~~~~~
* Added new ``LIBRARY_COLLECTION_CREATED``, ``LIBRARY_COLLECTION_UPDATED`` and ``LIBRARY_COLLECTION_DELETED`` events in content_authoring.

[9.12.0] - 2024-07-31
---------------------

Expand Down
2 changes: 1 addition & 1 deletion openedx_events/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
more information about the project.
"""

__version__ = "9.12.0"
__version__ = "9.13.0"
14 changes: 14 additions & 0 deletions openedx_events/content_authoring/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,3 +194,17 @@ class ContentObjectData:
"""

object_id = attr.ib(type=str)


@attr.s(frozen=True)
class LibraryCollectionData:
"""
Data about changed content library Collection.

Arguments:
library_key (LibraryLocatorV2): a key that represents a Blockstore-based content library.
collection_id (int): an id (pk) that represents a collection associated with the content library.
"""

library_key = attr.ib(type=LibraryLocatorV2)
collection_id = attr.ib(type=int)
34 changes: 34 additions & 0 deletions openedx_events/content_authoring/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
CourseData,
DuplicatedXBlockData,
LibraryBlockData,
LibraryCollectionData,
XBlockData,
)
from openedx_events.tooling import OpenEdxPublicSignal
Expand Down Expand Up @@ -210,3 +211,36 @@
"content_object": ContentObjectData
}
)

# .. event_type: org.openedx.content_authoring.content.library.collection.created.v1
# .. event_name: LIBRARY_COLLECTION_CREATED
# .. event_description: emitted when a content library collection is created
# .. event_data: LibraryCollectionData
LIBRARY_COLLECTION_CREATED = OpenEdxPublicSignal(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradenmacdonald Are we allowed to put new signals in this repo? Or are we supposed to put them in https://github.com/openedx/openedx-events ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure. Maybe @mariajgrimaldi can answer? What's the difference between this signals.py and that signals.py?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow. This repo es openedx-events and both signals.py files are the same.

You are definitely allowed to propose new signal definitions in this repository and the location is correct. The idea of having the signal here instead of in the edx-platform code is that plugins that will listen for the signal can include this lightweight library in their dependencies instead of requiring edx-platform all the time.

Copy link

@bradenmacdonald bradenmacdonald Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol whoops, please ignore my confusion. I thought this was edx-platform :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Happy to address this in depth. As before, if you are planning to add a signal into edx-platform, then it would be better to write it here so plugins can use that without the large import.
However, other pattern we have seen is when a plugin defines a new signal and uses it in its own code. In that case if reuse of said signal is not a goal from the devs, then the definition can be left in the plugin as you could import that plugin as a library if you are writing a second level library/plugin.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the noise! I could have sworn there was a signals.py file in openedx-learning, but it's not there now, so not sure what I was on about :)

Copy link
Contributor

@pomegranited pomegranited Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it was here in this closed PR! signals.py. I'm not going nuts.. 😊

event_type="org.openedx.content_authoring.content.library.collection.created.v1",
navinkarkera marked this conversation as resolved.
Show resolved Hide resolved
data={
"library_collection": LibraryCollectionData
}
)

# .. event_type: org.openedx.content_authoring.content.library.collection.updated.v1
# .. event_name: LIBRARY_COLLECTION_UPDATED
# .. event_description: emitted when when a content library collection is updated
# .. event_data: LibraryCollectionData
LIBRARY_COLLECTION_UPDATED = OpenEdxPublicSignal(
event_type="org.openedx.content_authoring.content.library.collection.updated.v1",
navinkarkera marked this conversation as resolved.
Show resolved Hide resolved
data={
"library_collection": LibraryCollectionData
}
)

# .. event_type: org.openedx.content_authoring.content.library.collection.deleted.v1
# .. event_name: LIBRARY_COLLECTION_DELETED
# .. event_description: emitted when an when a content library collection is deleted
# .. event_data: LibraryCollectionData
LIBRARY_COLLECTION_DELETED = OpenEdxPublicSignal(
event_type="org.openedx.content_authoring.content.library.collection.deleted.v1",
navinkarkera marked this conversation as resolved.
Show resolved Hide resolved
data={
"library_collection": LibraryCollectionData
}
)
25 changes: 25 additions & 0 deletions ...s/schemas/org+openedx+content_authoring+content+library+collection+created+v1_schema.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"name": "CloudEvent",
"type": "record",
"doc": "Avro Event Format for CloudEvents created with openedx_events/schema",
"fields": [
{
"name": "library_collection",
"type": {
"name": "LibraryCollectionData",
"type": "record",
"fields": [
{
"name": "library_key",
"type": "string"
},
{
"name": "collection_id",
"type": "long"
}
]
}
}
],
"namespace": "org.openedx.content_authoring.content.library.collection.created.v1"
}
25 changes: 25 additions & 0 deletions ...s/schemas/org+openedx+content_authoring+content+library+collection+deleted+v1_schema.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"name": "CloudEvent",
"type": "record",
"doc": "Avro Event Format for CloudEvents created with openedx_events/schema",
"fields": [
{
"name": "library_collection",
"type": {
"name": "LibraryCollectionData",
"type": "record",
"fields": [
{
"name": "library_key",
"type": "string"
},
{
"name": "collection_id",
"type": "long"
}
]
}
}
],
"namespace": "org.openedx.content_authoring.content.library.collection.deleted.v1"
}
25 changes: 25 additions & 0 deletions ...s/schemas/org+openedx+content_authoring+content+library+collection+updated+v1_schema.avsc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"name": "CloudEvent",
"type": "record",
"doc": "Avro Event Format for CloudEvents created with openedx_events/schema",
"fields": [
{
"name": "library_collection",
"type": {
"name": "LibraryCollectionData",
"type": "record",
"fields": [
{
"name": "library_key",
"type": "string"
},
{
"name": "collection_id",
"type": "long"
}
]
}
}
],
"namespace": "org.openedx.content_authoring.content.library.collection.updated.v1"
}