feat: add event for course wide notification request #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadyousafarbi
force-pushed
the
saadyousafarbi/add-course-notification-event
branch
from
4f79c91 to
79c78f9
Compare
saadyousafarbi
force-pushed
the
saadyousafarbi/add-course-notification-event
branch
from
79c78f9 to
b75820a
Compare
saadyousafarbi
force-pushed
the
saadyousafarbi/add-course-notification-event
branch
3 times, most recently
from
c4b3a0c to
f977944
Compare
asadazam93
approved these changes
Nov 2, 2023
muhammadadeeltajamul
approved these changes
Nov 2, 2023
AhtishamShahid
approved these changes
Nov 2, 2023
saadyousafarbi
force-pushed
the
saadyousafarbi/add-course-notification-event
branch
3 times, most recently
from
8cee3f6 to
db3d9aa
Compare
|
Can we add more information about the event? So we have more context about it. I noticed you attached a jira issue but it's private. |
|
@mariajgrimaldi sorry about the private jira link. |
saadyousafarbi
force-pushed
the
saadyousafarbi/add-course-notification-event
branch
2 times, most recently
from
849408e to
1e8a932
Compare
mariajgrimaldi
approved these changes
Nov 13, 2023
saadyousafarbi
force-pushed
the
saadyousafarbi/add-course-notification-event
branch
from
1e8a932 to
86734c3
Compare
…ith wider audience
saadyousafarbi
force-pushed
the
saadyousafarbi/add-course-notification-event
branch
from
86734c3 to
e1a2c30
Compare
|
@mariajgrimaldi i have made the updates requested! |
|
Thank you! I'll be merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds the
COURSE_NOTIFICATION_REQUESTEDevent, that will be emitted whenever there is a request for a notification to be sent to all learners within a course.The event will be emitted whenever there is a request for a notification to be sent out to a course-wide audience. The event has the
course_keyparam identifying the course, and also provides theaudience_filterparam to specify subset of users within a course that the notification should be sent out to. Example of scenarios where this event could be used:The event also contains fields like
app_name,notification_type,content_contextandcontent_urlthat contain information about the notification, and it's content.The notification app in
edx-platformwill listen to this event, and process the notification request for course-wide notifications, delivering the notification to appropriate audience (PR to be created onedx-platformonce this gets merged, and event becomes available).Other
ISSUE: https://2u-internal.atlassian.net/browse/INF-1134
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.