Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added path field to the DownloadData model. #70

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

volodymyr-chekyrta
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta commented Sep 7, 2023

All control over files was refactored using the new path field.

  • This pull request adds more control over file storage.
  • This PR is motivated by the future HLS video storage feature, where we cannot control where the files are stored, but we can store their path in the system.

All control over files was refactored using the new path field.
@volodymyr-chekyrta volodymyr-chekyrta requested a review from a team as a code owner September 7, 2023 19:50
@volodymyr-chekyrta volodymyr-chekyrta merged commit 89530b4 into develop Sep 8, 2023
@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/persistence_save_file_path branch September 8, 2023 08:27
volodymyr-chekyrta added a commit that referenced this pull request Sep 22, 2023
* bug fix (#57)

* Fix DisclosureGroup fields bug on SignUpView (#58)

* Hide no discussion while update (#59)

* Consolidating Databases and Refactoring Module Logic (#60)

This merge request aims to consolidate multiple databases into a single one for improved efficiency and maintainability in the OpenEdx project.
The changes involve creating a new class, DatabaseManager, which handles CoreData operations and moving CoreData logic from specific modules to this central manager.
Additionally, a new method, deleteAllFiles(), is added to the DownloadManager class for convenient file deletion upon user logout.

* Migrate all colors to Theme (#61)

* Added support for multiple color schemes to quickly switch between educational platforms. Updated variables throughout the project accordingly.

* Fix not updating completion error (#64)

completion doesn't update status when user has finished learning the contents of a unit

* Remove custom navigation controller (#63)

* Remove custom navigation controller
Change navigation controller from custom to system for feature changes and adding possibility to swipe gestures

* disable routing whenever handouts is empty (#66)

* Fix the isMobileData variable in the Connectivity module. (#67)

Add the possibility to play videos with sound in silent mode.

* encoded video dissmiss by device rotation (#68)

* fixed

* Separate AppStorage to protocol oriented architecture. (#69)

* Separate AppStorage to protocol oriented architecture.

* Added path field to the DownloadData model. (#70)

* Added path field to the DownloadData model.
All control over files was refactored using the new path field.

* Fix CourseContainerViewModelTests

* September bugfixes (#71)

* fix incorrect back button on the course screen

* Fix issue on Delete account view. The inactive button is clickable.

* change CourseDetailsEndpoint to CourseEndpoint
fix WebView bug with iframe
fix doubling courses on Dashboard after subscribe to a new course

* Create 0001-strategy-for-maintaining-OS-versions.rst (#72)

* Create 0001-strategy-for-maintaining-OS-versions.rst

* Update 0001-strategy-for-maintaining-OS-versions.rst

* Deprecate iOS 14 (#74)

* Deprecate iOS 14

Remove isIOS14 in ViewExtension

Change deployment target to iOS 15

Add a new RefreshableScrollView for better pull to refresh animation on any iOS
update loading logic in DiscoveryViewModel, ThreadViewModel, and PostsViewModel for a smooth refreshing

* Update refreshable ScrollView to native for iOS 16+ (#75)

* Update refreshable ScrollView to native for iOS 16+

* Codestyle improvements (#76)

* codestyle improvements

* remove unused code

* ios 17 bugfixes (#77)

* bugfixes

* Change license to Apache (#78)

---------

Co-authored-by: IvanStepanok <[email protected]>
volodymyr-chekyrta pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants