Merge pull request #431 from saeedbashir/saeed/sliding_bar_theme

chore: Sliding course menu theme enhancement
openedx · May 9, 2024 · 83ce168 · 83ce168
2 parents bd9f081 + 102e44c
commit 83ce168
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 1 deletion.
diff --git a/Core/Core/View/Base/ScrollSlidingTabBar/ScrollSlidingTabBar.swift b/Core/Core/View/Base/ScrollSlidingTabBar/ScrollSlidingTabBar.swift
@@ -100,7 +100,7 @@ extension ScrollSlidingTabBar {
                             }
                             .accentColor(
                                 isSelected(index: obj.offset)
-                                ? Theme.Colors.white
+                                ? Theme.Colors.slidingSelectedTextColor
                                 : Theme.Colors.slidingTextColor
                             )
                         }

diff --git a/...heme/Assets.xcassets/Colors/SlidingTabBar/slidingSelectedTextColor.colorset/Contents.json b/...heme/Assets.xcassets/Colors/SlidingTabBar/slidingSelectedTextColor.colorset/Contents.json
@@ -0,0 +1,38 @@
+{
+  "colors" : [
+    {
+      "color" : {
+        "color-space" : "srgb",
+        "components" : {
+          "alpha" : "1.000",
+          "blue" : "1.000",
+          "green" : "1.000",
+          "red" : "1.000"
+        }
+      },
+      "idiom" : "universal"
+    },
+    {
+      "appearances" : [
+        {
+          "appearance" : "luminosity",
+          "value" : "dark"
+        }
+      ],
+      "color" : {
+        "color-space" : "srgb",
+        "components" : {
+          "alpha" : "1.000",
+          "blue" : "1.000",
+          "green" : "1.000",
+          "red" : "1.000"
+        }
+      },
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}
diff --git a/Theme/Theme/SwiftGen/ThemeAssets.swift b/Theme/Theme/SwiftGen/ThemeAssets.swift
@@ -56,6 +56,7 @@ public enum ThemeAssets {
   public static let secondaryButtonBorderColor = ColorAsset(name: "SecondaryButtonBorderColor")
   public static let secondaryButtonTextColor = ColorAsset(name: "SecondaryButtonTextColor")
   public static let shadowColor = ColorAsset(name: "ShadowColor")
+  public static let slidingSelectedTextColor = ColorAsset(name: "slidingSelectedTextColor")
   public static let slidingStrokeColor = ColorAsset(name: "slidingStrokeColor")
   public static let slidingTextColor = ColorAsset(name: "slidingTextColor")
   public static let snackbarErrorColor = ColorAsset(name: "SnackbarErrorColor")

diff --git a/Theme/Theme/Theme.swift b/Theme/Theme/Theme.swift
@@ -65,6 +65,7 @@ public struct Theme {
         public private(set) static var infoColor = ThemeAssets.infoColor.swiftUIColor
         public private(set) static var irreversibleAlert = ThemeAssets.irreversibleAlert.swiftUIColor
         public private(set) static var slidingTextColor = ThemeAssets.slidingTextColor.swiftUIColor
+        public private(set) static var slidingSelectedTextColor = ThemeAssets.slidingSelectedTextColor.swiftUIColor
         public private(set) static var slidingStrokeColor = ThemeAssets.slidingStrokeColor.swiftUIColor
         public private(set) static var primaryHeaderColor = ThemeAssets.primaryHeaderColor.swiftUIColor
         public private(set) static var secondaryHeaderColor = ThemeAssets.secondaryHeaderColor.swiftUIColor