Isanka/dev

[isankadn]

Description:

Related to openedx/frontend-component-header#276

On the MFE learning top menu, the "Help" link is currently displayed by default.

With this change, the "Help" menu will only be visible if the "SUPPORT URL" variable is not empty.

[openedx-webhooks]

Thanks for the pull request, @isankadn! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

[arbrandes]

@isankadn, some linting problems here, too. Also, we need the CLA signed for this one as well. Thanks!

[codecov]

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (ebf587c) compared to base (99d81e8).
Patch has no changes to coverable lines.

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #499   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines           7       7           
======================================
  Misses          7       7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[e0d]

@isankadn it looks like the commit lint messages, see the docs on conventional commits here.

There are instructions for submitting a CLA in the welcome message above.

[mphilbrick211]

Hi @isankadn! Just following up on the CLA form. In order to push this PR through, you'll need to fill one out. Please let me know if you have any questions. Thanks!

[mphilbrick211]

Hi @isankadn! You should be able to re-run tests now and have your CLA check go through. Once you're all set with that, please take a look at the changes Adolfo has requested. Thank you!

[arbrandes]

Can we get a squash into a single commit, with a conventional commit title, here too? Thanks!

[mphilbrick211]

Hi @isankadn - just following up on this to see if you plan to re-run the failing tests?

[mphilbrick211]

Hi @isankadn! Friendly follow-up on your CLA. If you have submitted it and it was processed the CLA check will turn green when you run the tests. Please let us know if you have any questions.

[mphilbrick211]

Hi @isankadn! Friendly follow-up on your CLA. If you have submitted it and it was processed the CLA check will turn green when you run the tests. Please let us know if you have any questions.

Hi @isankadn Just checking in on this. Do you plan to pursue this pull request?

[mphilbrick211]

Hi @isankadn - friendly ping on this :) Please let us know if plan to pursue this pull request. Thank you!

[mphilbrick211]

Hi @isankadn! We need to close this PR for now due to inactivity. If you choose to pursue in the future, it can be reopened. Thanks!

[openedx-webhooks]

@isankadn Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.