build: upgrade to node16

[binodpant]

Description:
Was awaiting #245 so now this is unblocked

locally: Devs should ideally use nvm use after syncing repo, clean out node modules and npm ci : nvm automatically chooses latest node/npm version for v16 based on .nvmrc file
in Github builds: tooling is configured to honor .nvmrc already

Alternative to use nvm is to manually install node16/npm8 but note that different projects may be (as of now) using different node versions, so nvm is highly recommended

Description:

Upgrades project to use nvmrc and node16 (specified in nvmrc file)
Local dev users should either:

• run nvm use after syncing this change (if they use nvm), OR,
• install node16 and npm8 after syncing this change, to stay current with the nvmrc based node/npm versions.

NOTE: since nvmrc uses the v16 version, nvm will choose the latest node and npm versions under the major version (v16.y.z for node and v8.y.z for npm) applicable when you run nvm use

Describe what this pull request changes, and why. Include implications for people using this change.

Merge checklist:

• Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
• Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
• Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

• After the build finishes for the merged commit, verify the new release has been pushed to NPM.

[codecov-commenter]

Codecov Report

Merging #259 (5985263) into master (402cf76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files          38       38           
  Lines         885      885           
  Branches      163      163           
=======================================
  Hits          715      715           
  Misses        159      159           
  Partials       11       11           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402cf76...5985263. Read the comment docs.

[binodpant]

my editor / vscode reformatted this file if this is not acceptable, I can revert! I have to check what settings exist that are doing this

[UsamaSadiq]

This shouldn't be an issue. If this is the only change, then you can merge with this change since both versions are syntactically correct.

[adamstankiewicz]

FWIW, I don't think the "**" is needed here. Just having pull_request under on should suffice to get the workflow to run on all Paragon PR updates.

[binodpant]

Actually there is an issue!

With new node version, start fails like this

$ npm start
[webpack-cli] TypeError: Cannot read properties of undefined (reading 'tap')
    at HtmlWebpackPlugin.apply (/private/tmp/frontend-platform/frontend-platform/node_modules/@edx/frontend-build/node_modules/html-webpack-plugin/index.js:40:31)
    at WebpackCLI.webpack (/private/tmp/frontend-platform/frontend-platform/node_modules/webpack/lib/webpack.js:51:13)
    at WebpackCLI.createCompiler (/private/tmp/frontend-platform/frontend-platform/node_modules/webpack-cli/lib/webpack-cli.js:2191:23)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Command.<anonymous> (/private/tmp/frontend-platform/frontend-platform/node_modules/@webpack-cli/serve/lib/index.js:98:30)
    at async Promise.all (index 1)
    at async Command.<anonymous> (/private/tmp/frontend-platform/frontend-platform/node_modules/webpack-cli/lib/webpack-cli.js:1672:7)
/tmp/frontend-platform/frontend-platform (master ✘)✹ ᐅ