-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable header to accept custom menus #466
Conversation
b45023b
to
613ffc8
Compare
0c6e968
to
b3d375f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 66.86% 70.42% +3.55%
==========================================
Files 24 24
Lines 338 355 +17
Branches 78 88 +10
==========================================
+ Hits 226 250 +24
+ Misses 110 103 -7
Partials 2 2 ☔ View full report in Codecov by Sentry. |
cf7a4b1
to
57f1b04
Compare
@arbrandes Can you give an estimated time on when you will be able to review this PR? |
2dede18
to
004592a
Compare
@zainab-amir, I'll do my best to get to it today. |
004592a
to
e6aa4be
Compare
Hi @arbrandes, waiting for your review on this PR. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all of the documentation nit picks! Approving from my end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find anything to object to: thanks for this, and apologies for the long delay in reviewing it!
))} | ||
</MenuContent> | ||
</Menu> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, I could not find any MFEs that use this, either.
This PR adds the following functionality
appMenu
fromDesktopHeader
because its usage could not be found. (reference)(Please let me know if I am missing its usage)Screenshots of using custom headers for replicating different MFE headers.
Note: Screenshots are with local setup.