-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow runtime configuration #144
feat: allow runtime configuration #144
Conversation
Thanks for the pull request, @dcoa! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
f9f26e2
to
b26131d
Compare
@muselesscreator, @leangseu-edx, can you help us find a pair of eyes to review this one? There's a time component: we want to get this MFE into Tutor/Olive, and to do so we need to have the dynamic configuration support this PR provides merged in the next 2 weeks, give or take. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 111 +2
Lines 1077 1081 +4
Branches 158 158
=========================================
+ Hits 1077 1081 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I made some change for testing and add it to this branch https://github.com/edx/frontend-app-ora-grading/tree/dcoa/allow-runtime-config because I don't have permission to overwriting this. |
Thanks for your help, I integrated the changes. |
Thanks a bunch, @leangseu-edx! |
* feat: allow runtime configuration * test: organize Head test
Description
This PR is part of the work to make it possible to configure the frontend applications at runtime (you can referer to this openedx/wg-frontend#103).
Changes
Screenshot
Values come from runtime configuration
How to test
MFE_CONFIG_API_URL
andAPP_ID
in the env file and add the api url ( To test this you can use the API from this feat: add mfe config api edx-platform#30473 or use an external tool to mock the API response).Note: You can combine buildtime and runtime configuration