Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed width issues of old and new sidebar #1374

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

sundasnoreen12
Copy link
Contributor

INF-1373

Description
Fixed following issues:

  1. The width of the new in-context sidebar remained fixed, causing UI disturbances when the number of units increased due to the sidebar's 'stick to the top' property.
  2. The width of the sidebar exhibited inconsistencies across different screen sizes as the number of units increased.

@sundasnoreen12 sundasnoreen12 force-pushed the sundas/INF-1373 branch 3 times, most recently from 90c6ca8 to 0546454 Compare April 29, 2024 15:14
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (cf3a91d) to head (182e7cb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
+ Coverage   88.30%   88.32%   +0.02%     
==========================================
  Files         292      292              
  Lines        5002     5012      +10     
  Branches     1267     1272       +5     
==========================================
+ Hits         4417     4427      +10     
  Misses        569      569              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit 799e57f into master Apr 30, 2024
7 checks passed
@awais-ansari awais-ansari deleted the sundas/INF-1373 branch April 30, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants