feat: gate visibility of chat component by active attempt #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/courseware/course/chat/Chat.jsx
Outdated
| const shouldDisplayChat = ( | ||
| enabled | ||
| && (hasVerifiedEnrollment || isStaff) // display only to verified learners or staff | ||
| && !endDatePassed() | ||
| && !hasActiveAttemptId |
There was a problem hiding this comment.
Nit: I think you can just use !activeAttemptId, right? That'll cast activeAttemptId to a boolean and then negate it. hasActiveAttemptId is unnecessary, because you're negating the value activeAttemptId twice.
alangsto
force-pushed
the
alangsto/gate_chat_visibility_by_exam
branch
4 times, most recently
from
69e3208 to
be646af
Compare
alangsto
force-pushed
the
alangsto/gate_chat_visibility_by_exam
branch
from
be646af to
50b4ecf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1282 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 291 291
Lines 4929 4931 +2
Branches 1242 1243 +1
=======================================
+ Hits 4354 4356 +2
Misses 561 561
Partials 14 14 ☔ View full report in Codecov by Sentry. |
MichaelRoytman
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMO-86
The chat component should not be visible if a learner has an active attempt. The special exams library has been refactored so that the exam state is accessible outside of components defined in the exams library. This PR makes use of the newly available exams reducer to gave chat visibility.