-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show message in course outline when hide from toc is enabled #1262
Conversation
Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
6bfb2b9
to
020538f
Compare
020538f
to
6c15716
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 88.38% 88.38%
=======================================
Files 291 291
Lines 4949 4951 +2
Branches 1251 1253 +2
=======================================
+ Hits 4374 4376 +2
Misses 561 561
Partials 14 14 ☔ View full report in Codecov by Sentry. |
44a2aee
to
99da5b8
Compare
980ae58
to
4acc84e
Compare
@BryanttV Thank you for this contribution! Please let us know when the build is green and the changes are ready for review. |
Hi @jmakowski1123, since this PR is for an existing feature enhancement proposal, I'm flagging it for product review. I'll cross-link from the roadmap ticket (openedx/platform-roadmap#301) shortly, too. |
0ef2825
to
895b8a9
Compare
895b8a9
to
b5e2772
Compare
b5e2772
to
1ba0b4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this in my local environment, and it's working as described in the cover letter. Thank you!
1ba0b4f
to
5f5c7e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments were addressed, LGTM!
Show message in course outline when Hide From TOC is enabled https://openedx.atlassian.net/wiki/spaces/OEPM/pages/3853975595/Feature+Enhancement+Proposal+Hide+Sections+from+course+outline
5f5c7e2
to
ff13651
Compare
Hello there, @itsjeyd; this PR is also waiting for a maintainer review. Let me know if there's anything else we could do. |
Fired off a sandbox. Let's see how it goes. |
Sandbox deployment successful 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works and looks good. Approved!
@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds messages in the course outline when the hide from toc is enabled from the sections (this functionality is added in this PR). From now on, from the hidden sections and their children (subsections), a message will be displayed only to the instructor indicating that these blocks are hidden from learners.
Screenshots
Supporting information
These changes are part of the effort made to implement Feature Enhancement Proposal: Hide Sections from Course Outline
Dependencies
Important
This PR needs the changes made from:
hide_from_toc
field in course blocks.Testing Instructions
Using tutor you can test these changes:
edx-platform
in a branch with the abovementioned changes.tutor mounts add frontend-app-learning
frontend-app-learning
folder and runnpm install
tutor config save
andtutor dev start -d