-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix dropdown menu in breadcrumbs #1190
fix: Fix dropdown menu in breadcrumbs #1190
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
=======================================
Coverage 87.87% 87.87%
=======================================
Files 263 263
Lines 4485 4485
Branches 1133 1133
=======================================
Hits 3941 3941
Misses 530 530
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Hi @Lunyachek, thank you for this contribution! I'm assuming that the changes are ready for review. If that's not the case please let me know. |
Palm backport: #1191 |
Hey @mattcarter, a friendly ping about this PR -- it's ready for engineering review. CC @openedx/content-aurora |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This bug was introduced in the latest versions of Paragon after adding the position: relative parameter to the .pgn__menu-select-popup element. You can find the relevant pull request here: openedx/paragon#1281
I have been in communication with the Paragon team, and they convinced me that this fix is necessary for the Menu component. As a result, we have decided to include this minor fix in the Learning MFE.
Before fix:
2023-09-21.00.41.49.mov
After fix:
2023-09-21.00.38.07.mov