Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow override of plugin.modal height #1184

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

muselesscreator
Copy link
Contributor

@muselesscreator muselesscreator commented Sep 13, 2023

The height of the modal in modal.plugin call from the Unit defaults to 100vh, which can lead to visual issues with consumed interfaces. This allows the consumer to pass a height field (preferrably still in vh) that will be respected when creating the modal.

Without overridden height:
image
image

With overridden height:
image

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f58d6d6) 87.86% compared to head (9eda837) 87.87%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1184   +/-   ##
=======================================
  Coverage   87.86%   87.87%           
=======================================
  Files         263      263           
  Lines        4483     4485    +2     
  Branches     1133     1133           
=======================================
+ Hits         3939     3941    +2     
  Misses        530      530           
  Partials       14       14           
Files Changed Coverage Δ
.../courseware/course/sequence/Unit/ContentIFrame.jsx 95.00% <100.00%> (ø)
...e/course/sequence/Unit/hooks/useModalIFrameData.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muselesscreator muselesscreator merged commit c8e32c3 into master Sep 15, 2023
@muselesscreator muselesscreator deleted the bw/modal_plugin_height branch September 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants