Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix dropdown menu in breadcrumbs #1190

Conversation

Lunyachek
Copy link
Contributor

This bug was introduced in the latest versions of Paragon after adding the position: relative parameter to the .pgn__menu-select-popup element. You can find the relevant pull request here: openedx/paragon#1281

I have been in communication with the Paragon team, and they convinced me that this fix is necessary for the Menu component. As a result, we have decided to include this minor fix in the Learning MFE.

Before fix:

2023-09-21.00.41.49.mov

After fix:

2023-09-21.00.38.07.mov

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 20, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 20, 2023

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (168ed1e) 87.87% compared to head (00c4849) 87.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1190   +/-   ##
=======================================
  Coverage   87.87%   87.87%           
=======================================
  Files         263      263           
  Lines        4485     4485           
  Branches     1133     1133           
=======================================
  Hits         3941     3941           
  Misses        530      530           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Oct 10, 2023

Hi @Lunyachek, thank you for this contribution! I'm assuming that the changes are ready for review. If that's not the case please let me know.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 10, 2023
@itsjeyd itsjeyd requested a review from mattcarter October 10, 2023 07:48
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

Palm backport: #1191

@itsjeyd
Copy link

itsjeyd commented Nov 2, 2023

Hey @mattcarter, a friendly ping about this PR -- it's ready for engineering review.

CC @openedx/content-aurora

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@mattcarter mattcarter merged commit 9a0cdc0 into openedx:master Nov 8, 2023
5 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
@Lunyachek Lunyachek deleted the lunyachek/fix/breadcrumbs-dropdown-menu-fix branch December 28, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants