fix: MailToLink to account for no emails #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/containers/CourseCard/components/CourseCardBanners/CertificateBanner.test.jsx
Outdated
Show resolved
Hide resolved
cintnguyen
force-pushed
the
emailtolink
branch
from
63be1e4 to
7390851
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 96.46% 96.45% -0.01%
==========================================
Files 195 194 -1
Lines 1839 1835 -4
Branches 322 322
==========================================
- Hits 1774 1770 -4
Misses 60 60
Partials 5 5 ☔ View full report in Codecov by Sentry. |
25 tasks
|
@openedx/2u-aperture, can we get eyes on this one? Thanks! |
|
Oh, and @cintnguyen, mind rebasing? Thanks! |
cintnguyen
force-pushed
the
emailtolink
branch
from
7390851 to
b83f128
Compare
|
@arbrandes rebased, ci passed! |
hurtstotouchfire
added
the
needs maintainer attention
|
I'm going to start getting eyes on this today but most likely won't complete review until tomorrow morning. Just wanted to acknowledge that it's being looked at. |
justinhynes
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #226
Removed EmailLink component and refactored code to cover for the use case of not having an email provided. This led to also creating additional tests to cover for these snapshots.