Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add plugins framework to learner dash #215

Merged

Conversation

jsnwesson
Copy link
Contributor

@jsnwesson jsnwesson commented Oct 12, 2023

This PR adds the frontend plugin framework in Learner Home.

This PR also includes:

  • Add a PluginSlot to the Side Navigation Bar widget, both for LoadedSideBar and NoSideBar
  • Add mock config object to PluginSlot.js to explicitly pass URL of Profile Plugin
  • Remove the Optimizely experiments until we decide to bring any in (ie. Recommendations) for the POC

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (82ff0d7) 96.46% compared to head (bdbe684) 96.08%.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           aperture/PluggableDashPOC     #215      +/-   ##
=============================================================
- Coverage                      96.46%   96.08%   -0.39%     
=============================================================
  Files                            195      195              
  Lines                           1839     1839              
  Branches                         322      322              
=============================================================
- Hits                            1774     1767       -7     
- Misses                            60       67       +7     
  Partials                           5        5              
Files Coverage Δ
...shboardHeader/CollapsedHeader/CollapseMenuBody.jsx 88.88% <ø> (ø)
...rs/LearnerDashboardHeader/ExpandedHeader/index.jsx 100.00% <ø> (ø)
...ontainers/WidgetContainers/LoadedSidebar/index.jsx 100.00% <ø> (ø)
...ainers/WidgetContainers/NoCoursesSidebar/index.jsx 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One thing I noticed about the Optmizely variation error that we were seeing is that it can also be fixed by providing a default value when createContext is called here.

That ended up looking like this:

export const PaintedDoorExperimentContext = React.createContext({
  experimentVariation: '',
  isPaintedDoorNavbarBtnVariation: false,
  isPaintedDoorWidgetBtnVariation: false,
  isPaintedDoorControlVariation: false,
  experimentLoading: true,
});

I don't think this is blocking seeing as we are just trying to get the POC together but thought it was valuable... context 😉

@jsnwesson jsnwesson force-pushed the jwesson/install-frontend-plugin-framework branch from 086b3fb to bdbe684 Compare October 13, 2023 21:25
@jsnwesson
Copy link
Contributor Author

@MaxFrank13 frustratingly, the configuration you're suggesting already exists here, but the error message appears the same when they're toggled to true.

@jsnwesson jsnwesson merged commit 9c8629f into aperture/PluggableDashPOC Oct 13, 2023
7 of 8 checks passed
@jsnwesson jsnwesson deleted the jwesson/install-frontend-plugin-framework branch October 13, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants