-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add plugins framework to learner dash #215
build: add plugins framework to learner dash #215
Conversation
…d-plugin-framework
…m:openedx/frontend-app-learner-dashboard into jwesson/install-frontend-plugin-framework
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## aperture/PluggableDashPOC #215 +/- ##
=============================================================
- Coverage 96.46% 96.08% -0.39%
=============================================================
Files 195 195
Lines 1839 1839
Branches 322 322
=============================================================
- Hits 1774 1767 -7
- Misses 60 67 +7
Partials 5 5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One thing I noticed about the Optmizely variation error that we were seeing is that it can also be fixed by providing a default value when createContext
is called here.
That ended up looking like this:
export const PaintedDoorExperimentContext = React.createContext({
experimentVariation: '',
isPaintedDoorNavbarBtnVariation: false,
isPaintedDoorWidgetBtnVariation: false,
isPaintedDoorControlVariation: false,
experimentLoading: true,
});
I don't think this is blocking seeing as we are just trying to get the POC together but thought it was valuable... context 😉
086b3fb
to
bdbe684
Compare
@MaxFrank13 frustratingly, the configuration you're suggesting already exists here, but the error message appears the same when they're toggled to |
This PR adds the frontend plugin framework in Learner Home.
This PR also includes:
LoadedSideBar
andNoSideBar
PluginSlot.js
to explicitly pass URL of Profile Plugin