Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changed Order History header menu item title to Orders & Subscriptions #164

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

mrazadar
Copy link
Contributor

@mrazadar mrazadar commented Jun 14, 2023

Description

https://2u-internal.atlassian.net/browse/PON-88

This PR change the title Order History header menu item title to Orders & Subscriptions.

  • It ensures that the change is made for both Authenticated and Collapsible Header

Screenshots

image image

@mrazadar mrazadar self-assigned this Jun 14, 2023
@mrazadar mrazadar force-pushed the mrazadar/PON-88/orders-and-subscriptions branch from 3581ddc to 7200454 Compare June 14, 2023 21:09
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c458f49) 96.03% compared to head (a358a60) 96.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         177      177           
  Lines        1538     1538           
  Branches      270      270           
=======================================
  Hits         1477     1477           
  Misses         56       56           
  Partials        5        5           
Impacted Files Coverage Δ
...shboardHeader/CollapsedHeader/CollapseMenuBody.jsx 88.88% <ø> (ø)
...eader/ExpandedHeader/AuthenticatedUserDropdown.jsx 100.00% <ø> (ø)
src/containers/LearnerDashboardHeader/messages.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mrazadar mrazadar force-pushed the mrazadar/PON-88/orders-and-subscriptions branch 4 times, most recently from fa56b21 to 54dad1c Compare June 20, 2023 12:14
@mrazadar mrazadar force-pushed the mrazadar/PON-88/orders-and-subscriptions branch from 54dad1c to 6ebc945 Compare June 20, 2023 12:30
@NawfalAhmed NawfalAhmed self-requested a review June 20, 2023 12:38
@mrazadar mrazadar force-pushed the mrazadar/PON-88/orders-and-subscriptions branch from 5f79126 to a358a60 Compare June 20, 2023 19:03
@mrazadar mrazadar merged commit 5c52b68 into master Jun 21, 2023
@mrazadar mrazadar deleted the mrazadar/PON-88/orders-and-subscriptions branch June 21, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants