Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed sort and filter tour #638

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

awais-ansari
Copy link
Contributor

@awais-ansari awais-ansari commented Jan 6, 2024

INF-1172

Description

We have 2 product tours currently active:

  • Unresponded filter in discussions
  • Responses/comments sort in discussions

These features are not “new” especially to ~2000 users signing up daily. They have 3 more clicks to do before they can interact with discussions and the product tours may be somewhat distracting to a user. We need to deactivate all product tours that we created.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ee61d1c) 92.38% compared to head (f997c6e) 92.38%.

Files Patch % Lines
src/discussions/tours/DiscussionsProductTour.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         169      169           
  Lines        3452     3452           
  Branches      892      892           
=======================================
  Hits         3189     3189           
  Misses        243      243           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@awais-ansari awais-ansari merged commit 035d766 into master Jan 9, 2024
6 of 7 checks passed
@awais-ansari awais-ansari deleted the aansari/INF-1172 branch January 9, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants