Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: babel-plugin-react-intl to babel-plugin-formatjs migration #572

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Oct 4, 2023

Upgraded to fronted-build v13 which migrates deprecated babel-plugin-react-intl to babel-plugin-formatjs.
Changed i18n_extract script in package.json accordingly

Epic Link

Migrate off babel-plugin-react-intl in favor of babel-plugin-formatjs

How Has This Been Tested?

Compared src/i18n/transifex_input.json file before and after change

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@abdullahwaheed abdullahwaheed self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cb8ad3) 92.32% compared to head (c253319) 92.32%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         169      169           
  Lines        3451     3451           
  Branches      899      899           
=======================================
  Hits         3186     3186           
  Misses        244      244           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sundasnoreen12 sundasnoreen12 self-requested a review October 12, 2023 11:06
@sundasnoreen12 sundasnoreen12 force-pushed the abdullahwaheed/react-intl-to-formatjs branch from 1aeb8fb to a8b7764 Compare November 1, 2023 06:38
@abdullahwaheed abdullahwaheed force-pushed the abdullahwaheed/react-intl-to-formatjs branch from c9c8780 to c253319 Compare November 1, 2023 06:44
@sundasnoreen12 sundasnoreen12 force-pushed the abdullahwaheed/react-intl-to-formatjs branch from c253319 to bf2f0af Compare November 1, 2023 06:45
@abdullahwaheed abdullahwaheed force-pushed the abdullahwaheed/react-intl-to-formatjs branch from bf2f0af to c253319 Compare November 1, 2023 06:48
@abdullahwaheed abdullahwaheed merged commit 27f73e3 into master Nov 1, 2023
8 checks passed
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/react-intl-to-formatjs branch November 1, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants