Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now discussion sidebar modal appears above the fold #563

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

sundasnoreen12
Copy link
Contributor

INF-1033

Description

One of our partner’s has shared the following:

”When I've been testing out the discussion sidebar, when trying to add an image or code the modal that pops up is not actually visible, and requires scrolling to reach it. The post UI fades out like this with no indication that there's anything below it:

You then have to scroll down quite far to be able to add your image/code

Now for learning discussion side i fixed this issue by change the modal position from align center to align start.

Screenshots/sandbox (optional):

Screenshot 2023-09-12 at 1 35 07 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@sundasnoreen12 sundasnoreen12 merged commit af5b10a into master Sep 15, 2023
snglth pushed a commit to Abstract-Tech/community-theme-discussions that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants