Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved feedback widget behind the env variable #557

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

awais-ansari
Copy link
Contributor

@awais-ansari awais-ansari commented Aug 15, 2023

INF-1018

  • Remove the discussions INFO banner
  • Moved feedback widget behind the env variable

Dependency
edx-internal
edge-internal

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.01% 🎉

Comparison is base (61d0f9a) 92.30% compared to head (1ac8567) 92.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   92.30%   92.32%   +0.01%     
==========================================
  Files         170      169       -1     
  Lines        3471     3451      -20     
  Branches      906      899       -7     
==========================================
- Hits         3204     3186      -18     
+ Misses        246      244       -2     
  Partials       21       21              
Files Changed Coverage Δ
...c/discussions/discussions-home/DiscussionsHome.jsx 95.74% <ø> (-0.26%) ⬇️
src/discussions/messages.js 100.00% <ø> (ø)
src/index.jsx 0.00% <ø> (ø)
...c/discussions/discussions-home/FeedbackWrapper.jsx 92.85% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit 2609380 into master Aug 21, 2023
@awais-ansari awais-ansari deleted the aansari/INF-1018 branch August 21, 2023 09:49
@awais-ansari awais-ansari restored the aansari/INF-1018 branch September 7, 2023 11:16
@awais-ansari awais-ansari deleted the aansari/INF-1018 branch September 7, 2023 11:21
snglth pushed a commit to Abstract-Tech/community-theme-discussions that referenced this pull request Jan 9, 2024
* feat: remove InformationBanner from Discussion MFE

* fix: moved feedback widget behind the env variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants