feat: upgraded to node v18, added .nvmrc and updated workflows #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 170 170
Lines 3474 3474
Branches 905 905
=======================================
Hits 3192 3192
Misses 263 263
Partials 19 19
☔ View full report in Codecov by Sentry. |
BilalQamar95
force-pushed
the
bilalqamar95/node-v18-upgrade
branch
from
475aa43 to
72caaae
Compare
|
@BilalQamar95 Since v16 to v18 is a big jump we do not intend to merge this PR as it will be a bigger risk. We have tried upgrading it before and it broke on production. This should be done in two steps. First v16 to v17 and then v17 to v18 |
52 tasks
This PR upgrades node version to v18, @asadazam93 requested us to bump packages incrementally, so once #508 is merged this PR will be ready for review. |
There was a problem hiding this comment.
@BilalQamar95 package version PR update has been deployed on production. Production is working fine. Please feel free to continue working on this one.
3 tasks
BilalQamar95
force-pushed
the
bilalqamar95/node-v18-upgrade
branch
from
72caaae to
e78359d
Compare
|
@awais-ansari @asadazam93 its ready for review now |
awais-ansari
requested review from
asadazam93,
ayesha-waris and
muhammadadeeltajamul
ayesha-waris
approved these changes
May 25, 2023
abdullahwaheed
pushed a commit
that referenced
this pull request
May 26, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: resolved eslint issues
abdullahwaheed
pushed a commit
that referenced
this pull request
May 26, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: resolved eslint issues
abdullahwaheed
pushed a commit
that referenced
this pull request
Jun 2, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: resolved eslint issues
mtyaka
pushed a commit
that referenced
this pull request
Jun 9, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: resolved eslint issues
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Oct 11, 2023
…dx#471) * feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: resolved eslint issues
moonesque
pushed a commit
to edSPIRIT/frontend-app-discussions
that referenced
this pull request
Nov 11, 2023
…dx#471) * feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: resolved eslint issues
moonesque
pushed a commit
to edSPIRIT/frontend-app-discussions
that referenced
this pull request
Nov 12, 2023
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Dec 11, 2023
…dx#471) * feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: resolved eslint issues
snglth
pushed a commit
to Abstract-Tech/community-theme-discussions
that referenced
this pull request
Jan 9, 2024
…dx#471) * feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: resolved eslint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade Node Js from 16 to 18
edx-internal PR
https://github.com/edx/edx-internal/pull/8340
edge-internal PR
https://github.com/edx/edge-internal/pull/529
Description
frontend-platform&frontend-buildversionseslintissues