feat: Support runtime configuration #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
6 tasks
arbrandes
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #379 +/- ##
============================================================
Coverage ? 85.05%
============================================================
Files ? 134
Lines ? 2677
Branches ? 741
============================================================
Hits ? 2277
Misses ? 378
Partials ? 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
awais-ansari
approved these changes
Dec 9, 2022
3 tasks
moonesque
pushed a commit
to edSPIRIT/frontend-app-discussions
that referenced
this pull request
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it), but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization.
Almost all changes here relate to the
LMS_BASE_URLsetting, which in most places was treated as a constant.This is a backport to Olive of #377