Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handled thread not found result on frontend #360

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

mehaknasir
Copy link
Contributor

INF-669

Related Backend Change: openedx/edx-platform#31340

Focus on the IDs of the thread and course in the screenshot to understand the fix:

original course with thread
Screen Shot 2022-11-24 at 3 08 12 PM

course trying to fetch a thread that does not belong to it
Screen Shot 2022-11-24 at 3 07 39 PM

also handled for the edit use case
Screen Shot 2022-11-24 at 3 07 56 PM

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 85.19% // Head: 85.09% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (ece0f4b) compared to base (5c3d561).
Patch coverage: 77.77% of modified lines in pull request are covered.

❗ Current head ece0f4b differs from pull request most recent head e685fb9. Consider uploading reports for the commit e685fb9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   85.19%   85.09%   -0.11%     
==========================================
  Files         134      134              
  Lines        2675     2683       +8     
  Branches      737      742       +5     
==========================================
+ Hits         2279     2283       +4     
- Misses        374      378       +4     
  Partials       22       22              
Impacted Files Coverage Δ
src/discussions/comments/messages.js 100.00% <ø> (ø)
src/discussions/posts/post-editor/messages.js 100.00% <ø> (ø)
src/discussions/posts/post-editor/PostEditor.jsx 85.14% <20.00%> (-2.61%) ⬇️
src/discussions/comments/CommentsView.jsx 95.08% <100.00%> (+0.34%) ⬆️
src/discussions/comments/comment/Comment.jsx 95.55% <100.00%> (+0.10%) ⬆️
src/discussions/posts/data/api.js 91.89% <100.00%> (ø)
src/discussions/posts/data/thunks.js 87.06% <100.00%> (-0.87%) ⬇️
src/discussions/posts/data/slices.js 79.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mehaknasir mehaknasir force-pushed the inf-669 branch 2 times, most recently from dbf4707 to 754e6d7 Compare November 30, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants