Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: babel-plugin-react-intl to babel-plugin-formatjs migration #151

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Oct 4, 2023

Upgraded to fronted-build v13 which migrates deprecated babel-plugin-react-intl to babel-plugin-formatjs.
Changed i18n_extract script in package.json accordingly

Epic Link

Migrate off babel-plugin-react-intl in favor of babel-plugin-formatjs

@abdullahwaheed abdullahwaheed self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56e1781) 83.01% compared to head (248307e) 83.01%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          46       46           
  Lines         683      683           
  Branches      132      132           
=======================================
  Hits          567      567           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sundasnoreen12 sundasnoreen12 self-requested a review October 12, 2023 11:07
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for taking a while to get to this one. I can merge as soon as we resolve conflicts.

@abdullahwaheed abdullahwaheed merged commit cf4b632 into master Nov 14, 2023
7 checks passed
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/react-intl-to-formatjs branch November 14, 2023 07:58
@abdullahwaheed abdullahwaheed restored the abdullahwaheed/react-intl-to-formatjs branch November 14, 2023 09:03
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/react-intl-to-formatjs branch November 14, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants