-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add In progress message on import taxonomy #953
feat: Add In progress message on import taxonomy #953
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #953 +/- ##
==========================================
+ Coverage 92.06% 92.09% +0.02%
==========================================
Files 685 685
Lines 12054 12093 +39
Branches 2626 2609 -17
==========================================
+ Hits 11098 11137 +39
Misses 920 920
Partials 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @ChrisChV Looks good to me, great work!
I just noticed something when importing, not really related to these changes specifically. When importing a large taxonomy, like the Light Cast Taxonomy, it takes a long time (10-15min+) for the /import
request to complete successfully. In some cases, it takes longer, and the memory usage fills up resulting in the cms container restarting (my docker memory limit was set to 30gb, I increased it to 45gb).
When that happens, I get the alert error, however I can see the imported taxonomy in the list, containing all the tags. For smaller taxonomies (like two level
and languages
) it works fine, and medium sized (like FlatTaxonomy
) it takes 3-4min to complete successfully.
I'm just wondering if that is something you also experienced when importing large taxonomies locally?
- I tested this: I followed the testing instructions.
- I read through the code
- I checked for accessibility issues
-
Includes documentation
@yusuf-musleh Thanks for the review.
I've tried it on my local devstack and had the same results. I created openedx/modular-learning#213 so we can check further on this issues. CC @bradenmacdonald |
e47f0f5
to
4ac066a
Compare
Message added as a toast
4ac066a
to
1054a45
Compare
@xitij2000 Can you please review and merge this ASAP? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Adds
In progress
message when import a taxonomySupporting information
Testing instructions
Import
button.