Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add In progress message on import taxonomy #953

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Apr 16, 2024

Description

Adds In progress message when import a taxonomy

image

Supporting information

Testing instructions

  • Make sure you have some sample taxonomy/tags data setup: https://github.com/open-craft/taxonomy-sample-data
  • Make sure you have taxonomies list page enabled: new_studio_mfe.use_tagging_taxonomy_list_page
  • Navigate to the taxonomies list page.
  • Click on Import button.
  • Follow the import workflow.
  • Verify the message after finish the workflow.

@ChrisChV ChrisChV requested a review from a team as a code owner April 16, 2024 19:20
@ChrisChV ChrisChV marked this pull request as draft April 16, 2024 19:21
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 16, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 16, 2024

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV marked this pull request as ready for review April 18, 2024 18:17
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (9327948) to head (1054a45).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
+ Coverage   92.06%   92.09%   +0.02%     
==========================================
  Files         685      685              
  Lines       12054    12093      +39     
  Branches     2626     2609      -17     
==========================================
+ Hits        11098    11137      +39     
  Misses        920      920              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ChrisChV Looks good to me, great work!

I just noticed something when importing, not really related to these changes specifically. When importing a large taxonomy, like the Light Cast Taxonomy, it takes a long time (10-15min+) for the /import request to complete successfully. In some cases, it takes longer, and the memory usage fills up resulting in the cms container restarting (my docker memory limit was set to 30gb, I increased it to 45gb).

When that happens, I get the alert error, however I can see the imported taxonomy in the list, containing all the tags. For smaller taxonomies (like two level and languages) it works fine, and medium sized (like FlatTaxonomy) it takes 3-4min to complete successfully.

I'm just wondering if that is something you also experienced when importing large taxonomies locally?

  • I tested this: I followed the testing instructions.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@ChrisChV
Copy link
Contributor Author

@yusuf-musleh Thanks for the review.

I'm just wondering if that is something you also experienced when importing large taxonomies locally?

I've tried it on my local devstack and had the same results. I created openedx/modular-learning#213 so we can check further on this issues. CC @bradenmacdonald

@ChrisChV ChrisChV force-pushed the chris/FAL-3707-import-progress-indicator branch from e47f0f5 to 4ac066a Compare April 29, 2024 18:36
@ChrisChV ChrisChV force-pushed the chris/FAL-3707-import-progress-indicator branch from 4ac066a to 1054a45 Compare April 29, 2024 18:51
@bradenmacdonald
Copy link
Contributor

@xitij2000 Can you please review and merge this ASAP?

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@arbrandes arbrandes merged commit 92b7ae1 into openedx:master May 8, 2024
6 checks passed
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the chris/FAL-3707-import-progress-indicator branch May 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Need a progress indicator for the taxonomy import process
5 participants