fix: fixed typo in updateContentTaxonomyTags URL [FC-0036]

[pomegranited]

Description

#787 introduced a bug in the URL used to update content tags, resulting in 404 errors from the backend.

This PR fixes that bug and the related tests.

Testing instructions

Setup:

1. Create test taxonomies, tags, orgs, and courses with https://github.com/open-craft/taxonomy-sample-data/
2. Run this PR's branch for course authoring.

Testing Tag Drawer:

1. Login to Studio as a non-superuser with course authoring permissions.
2. Visit the Sample Taxonomy Course course-v1:SampleTaxonomyOrg1+STC1+2023_1
3. Navigate to a Unit
4. Click "Manage Tags", either from the sidebar or the unit's menu
5. Add a bunch of tags at various hierarchy levels, and ensure they add as expected.
6. Delete some tags and ensure they delete as expected.

Internal-ref: FAL-3577

[openedx-webhooks]

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7aef6e) 90.58% compared to head (6821ebb) 90.58%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         511      511           
  Lines        8879     8879           
  Branches     1912     1912           
=======================================
  Hits         8043     8043           
  Misses        811      811           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rpenido]

LGTM @pomegranited! 👍

• I tested this using my local tutor stack, following the testing instructions
• I read through the code
• I checked for accessibility issues
• Includes documentation

I made a minor suggestion, but if @xitij2000 manages to review this today, I think we are fine without it.

[rpenido]

That way we avoid dealing with direct string manipulation for the URL (and it can handle more complicated things, like arrays in the query string)

  const url = getContentTaxonomyTagsApiUrl(contentId);
  const params = { taxonomy: taxonomyId };  
  const { data } = await getAuthenticatedHttpClient().put(url, { tags }, { params });

[pomegranited]

Ah cool, that's nicer.. fixed 6821ebb

[pomegranited]

@xitij2000 could you merge this when you're happy with it?

[pomegranited]

@xitij2000 I don't think the CI error is related to this change? But please let me know if there's something I need to do to resolve it.

[xitij2000]

@xitij2000 I don't think the CI error is related to this change? But please let me know if there's something I need to do to resolve it.

I'm rerunning the tests and will merge when they pass.

[openedx-webhooks]

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.