-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error page on invalid course key #761
feat: error page on invalid course key #761
Conversation
Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
8037c3f
to
0374f48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #761 +/- ##
==========================================
+ Coverage 89.56% 89.57% +0.01%
==========================================
Files 495 496 +1
Lines 8069 8077 +8
Branches 1697 1700 +3
==========================================
+ Hits 7227 7235 +8
Misses 815 815
Partials 27 27 ☔ View full report in Codecov by Sentry. |
f9139e2
to
b0064d5
Compare
b0064d5
to
56d53b4
Compare
@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Shows a "Not found" page when an invalid course key is in the URL.
Testing instructions
Deadline
None
Other information
Private-ref: https://tasks.opencraft.com/browse/BB-8262